A few days ago I shared a simple Vue.js demo for an app called INeedIt. While not a terribly a complex application, it was something fun to build just to get some practice with Vue. Before I shared that post, I let my friend Ted Patrick take a look at the code and he had some feedback I thought would be nice to incorporate into a second version. I've made his suggested changes and I thought I'd quickly review them here. This is version two of the app and I've already got a third version of the app to share later. Anyway, here are the changes he suggested.

First, and this is the simplest, was a change in the script tags I used. The first version had this:

<script src="https://unpkg.com/vue"></script>
<script src="https://unpkg.com/vue-router/dist/vue-router.js"></script>

This will load the most recent version of Vue, and the Vue Router, but also has some delays in terms of loading. How much of a delay? Half a second. While that doesn't sound like much, every delay adds up, and switching to a specific version removes that delay. Here is the simple update:

<script src="https://unpkg.com/vue@2.5.3/dist/vue.min.js"></script>
<script src="https://unpkg.com/vue-router@3.0.1/dist/vue-router.min.js"></script>

The second change was more important and fixes an obvious bug in the first version. My initial version used the created event to request the user's location. Unfortunately, this ran every time the route was loaded as the component was created each time the view was shown. Ted suggested a simple change to the code that addressed this.

He moved the data for the component (which included a few flags, the set of services, and the location) into the global scope. So the top of my app.js now has this:

const SEARCH_API = 'https://openwhisk.ng.bluemix.net/api/v1/web/rcamden%40us.ibm.com_My%20Space/googleplaces/search.json';
const DETAIL_API = 'https://openwhisk.ng.bluemix.net/api/v1/web/rcamden%40us.ibm.com_My%20Space/googleplaces/detail.json';

//used for search max distance
const RADIUS = 2000;

let model = {
		{"id":"accounting","label":"Accounting"},{"id":"airport","label":"Airport"},{"id":"amusement_park","label":"Amusement Park"},{"id":"aquarium","label":"Aquarium"},
		{"id":"travel_agency","label":"Travel Agency"},{"id":"university","label":"University"},
		{"id":"veterinary_care","label":"Veterinary Care"},{"id":"zoo","label":"Zoo"}

Once again I removed a bunch of the serviceTypes values to save space. Next, the component's data function was changed to this:

data:function() { 
	return model;

This will point to the global variable and ensure that the values are not lost when navigating away and then back again. Finally, the created event was changed to mounted and now checks for GPS data.

mounted:function() {
	this.$nextTick(function() {
		if(this.lat === null) {
			console.log('get geolocation', this.lat);
			let that = this;
			navigator.geolocation.getCurrentPosition(function(res) {
				that.lng = res.coords.longitude;
				that.lat = res.coords.latitude;
				that.loading = false;
			}, function(err) {
				that.loading = false;
				that.error = true;

I don't like having the flags in the global scope and if I cared enough I could get around that, but this did work well and made the application run quicker, all good things, right?

And that's it. As I said, not a lot of changes, but I wanted to separate them out so I could see a "progression" of the app. You can view the demo here: https://cfjedimaster.github.io/webdemos/ineedit2. The source for it may be found here: https://github.com/cfjedimaster/webdemos/tree/master/ineedit2

As always - feedback and comments are welcome. Tomorrow I'll be posting the third version which I'm pretty excited about! (Actually it's in GitHub now if you want to take a gander. ;)