Welcome to the second to last entry in my ColdFusion Newbie contest. I should be hitting up the last one tonight and announcing a winner tomorrow or Friday. These last two took a while because I wasn't able to get them running locally. Now normally that would be a disqualification. But - as both of these submissions had online versions, I decided to give them a review and include them in.
The first entry is Big Fat Monster from Nick Sweeney. The link in the previous sentence goes to the online version of the game. As with some of the other entries, the design is really nice. I hope these guys aren't cheating and using other designers. (And I swear I'm not jealous. Really.) You will have to register first and then log in. Once you do, you can create a monster with a few basic skins. There is a "Hall of Fame" on the home page which is pretty darn cool. Another cool feature is that your monster apparently gets into battles by itself while you are out. Now my list of "while you were out" battles included battles I actually participated in, so I'm not sure how that feature works. Once working with your monster, you have a pet, feed, nap, and fight option. The fighting is rather simple. You select an enemy and cross your fingers. There is also a cute "mBay" button to buy items, but I never saw any items there. (So it turns out this is a browser issue. I did a view source and saw items, but I never saw them in Firefox. I bet it works for IE. Now Nick definitely can't win! ;)
Digging into the code - I first noticed a full path in Application.cfm. This was a big problem in entry 7, so I've been keeping an eye out for it in other entries. As a reminder - anytime you hard code a path in your code your making it more difficult for you to move the code in the future. Keep that in mind.
Moving into index.cfm, I immediately see this:
<cfinvoke Component="Battles" Method="listBattles" ResultsLimit="50" Returnvariable="BattleList">
Which makes me wonder why an Application scoped CFC isn't being used instead. The CFC in question also lacks var scoping and output control. Although the var scope issue may be less of a problem since his CFC isn't cached, it is still something that can be fixed. I've been complaining about this in almost all the entries, but here is a quick example so you can see exactly what I mean:
<cffunction name="TodaysBattles" returntype="query" hint="Returns Todays Battles">
<cfargument name="ForMonster" required="yes" default=""> <cfset BattleDay = DateAdd("d",-1,Now())> <cfquery name="qryGetBattles" datasource="#REQUEST.DataSource#"> SELECT BigFatMonsterBattles.* FROM BigFatMonsterBattles Where BigFatMonsterBattles.AttackerID = #ARGUMENTS.ForMonster# AND BigFatMonsterBattles.BattleTime >= #BattleDay# ORDER By BigFatMonsterBattles.BattleTime DESC </cfquery> <cfreturn qryGetBattles>
In this case, all that is needed is to add two var statements. I'm also going to restrict the output and use cfqueryparam:
<cffunction name="TodaysBattles" returntype="query" hint="Returns Todays Battles" output="false">
<cfargument name="ForMonster" required="yes" default=""> <cfset var qryGetBattles = ""> <cfset var BattleDay = DateAdd("d",-1,Now())> <cfquery name="qryGetBattles" datasource="#REQUEST.DataSource#"> SELECT BigFatMonsterBattles.* FROM BigFatMonsterBattles Where BigFatMonsterBattles.AttackerID = <cfqueryparam cfsqltype="cf_sql_integer" value="#ARGUMENTS.ForMonster#"> AND BigFatMonsterBattles.BattleTime >=<cfqueryparam cfsqltype="cf_sql_timestamp" value="#BattleDay#"> ORDER By BigFatMonsterBattles.BattleTime DESC </cfquery> <cfreturn qryGetBattles>
Another problem I saw - and this really speaks to a common theme I'm seeing in this entry - is in monster_list.cfm. This is the main file run when working with your monster. In order to use this page you must be logged in. His code though does something like this:
<ciff logged in> lots of code <cfelse> link to let the user log in </cfif>
This is a mistake to me. First off - the Application.cfm file really should be handling this logic. Secondly, from just a readability standpoint, if I see a file that is 95% CFIF block then I see a problem. In general I try to avoid files like that. If I can't use Application.cfm (the CFIF may not be security related), I'll swap my CFIF logic to something more like this:
<cfif not X> blah <cfabort> </cfif> rest of page
One cool thing - the cfchart usage. This was also done well in entry 7 and I think serves as a reminder about how nice this feature is. As far as I know it wasn't updated for ColdFusion 8, which is unfortunate, but it is pretty powerful as is.
I was rather surprised by the code in monster_battle.cfm. I encourage folks to take a look at it. Apparently Nick used formulas from Diablo II and the code is an interesting read. I find it odd that he mixes in queries and CFCs calls though. This should all be in a CFC - but check the file out. It is definitely worth the time.
One big issue in monster_battle.cfm - notice that the monster value is passed in via URL parameter. Guess what happens if you change the value? No validation. I was able to make the code throw an error by just changing the ID to 1.
The last thing I'll point out is monster_action.cfm. This is the file that processes your actions. One of the things I noticed was a status code for the monster. So for example, if the status of your monster was 90-99, it meant it was dead. This leads to code that looks like so:
<!--- Make Sure The Monster Is NOT Dead - Then Do the work ---> <cfif #ThisMonster.MonsterStatus# LTE 89>
Can folks see the problem here? It isn't so much that a number is being used - but rather a hard coded number. I would have rewritten this more like so:
<!--- Make Sure The Monster Is NOT Dead - Then Do the work ---> <cfif thisMonster.isAlive()>
Abstract away the "is alive" logic. This is especially important since he repeats the logic multiple times on the page, and I'm sure throughout the application.